chore: Add @theme-ui/mdx to Gatsby install instructions#2373
Merged
lachlanjc merged 2 commits intosystem-ui:developfrom Dec 2, 2022
LekoArts:patch-1
Merged
chore: Add @theme-ui/mdx to Gatsby install instructions#2373lachlanjc merged 2 commits intosystem-ui:developfrom LekoArts:patch-1
@theme-ui/mdx to Gatsby install instructions#2373lachlanjc merged 2 commits intosystem-ui:developfrom
LekoArts:patch-1
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 50758b9:
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Curious for your thoughts—should the Gatsby plugin include MDX automatically? |
Contributor
Author
|
You're welcome! As for your question, as said in #832 (comment) I think the plugin shouldn't include any MDX handling anymore. It's easier for you and for the users in the longrun to not have to mess with MDX in Theme UI. If you use MDX + Gatsby, you'll already set up a provider anyways. |
Member
|
Ah right, sounds great. Totally agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I guess until Theme UI v1 (and it's clearly decided that the Gatsby plugin shouldn't include MDX anymore) the instructions need to be updated to also install
@theme-ui/mdxfor now.